Skip to content
Snippets Groups Projects
Commit 258ba261 authored by Dennis Gläser's avatar Dennis Gläser Committed by Timo Koch
Browse files

[Implicit][VolVars] Remove evalPoint, adjust update() interface

parent a514dfd0
No related branches found
No related tags found
1 merge request!617[WIP] Next
...@@ -46,59 +46,10 @@ class ImplicitVolumeVariables ...@@ -46,59 +46,10 @@ class ImplicitVolumeVariables
typedef typename GET_PROP_TYPE(TypeTag, GridView) GridView; typedef typename GET_PROP_TYPE(TypeTag, GridView) GridView;
typedef typename GridView::template Codim<0>::Entity Element; typedef typename GridView::template Codim<0>::Entity Element;
typedef typename GET_PROP_TYPE(TypeTag, FVElementGeometry) FVElementGeometry; typedef typename GET_PROP_TYPE(TypeTag, FVElementGeometry) FVElementGeometry;
typedef typename GET_PROP_TYPE(TypeTag, SubControlVolume) SubControlVolume;
typedef typename GET_PROP_TYPE(TypeTag, PrimaryVariables) PrimaryVariables; typedef typename GET_PROP_TYPE(TypeTag, PrimaryVariables) PrimaryVariables;
public: public:
// default constructor
ImplicitVolumeVariables()
{ evalPoint_ = 0; }
// copy constructor
ImplicitVolumeVariables(const ImplicitVolumeVariables &v)
{
evalPoint_ = 0;
priVars_ = v.priVars_;
extrusionFactor_ = v.extrusionFactor_;
}
/*!
* \brief Assignment operator
*/
ImplicitVolumeVariables &operator=(const ImplicitVolumeVariables &v)
{
evalPoint_ = 0;
priVars_ = v.priVars_;
extrusionFactor_ = v.extrusionFactor_;
return *this;
}
/*!
* \brief Sets the evaluation point used by the local jacobian.
*
* The evaluation point is only used by semi-smooth models.
*/
void setEvalPoint(const Implementation *ep)
{
evalPoint_ = ep;
Valgrind::CheckDefined(evalPoint_);
}
// /*!
// * \brief Returns the evaluation point used by the local jacobian.
// *
// * The evaluation point is only used by semi-smooth models.
// */
// const Implementation &evalPoint() const
// { return (evalPoint_ == 0)?asImp_():*evalPoint_; }
// /*!
// * \brief Set the volume variables which should be used as initial
// * conditions for complex calculations.
// */
// void setHint(const Implementation *hint)
// {}
/*! /*!
* \brief Update all quantities for a given control volume * \brief Update all quantities for a given control volume
...@@ -119,13 +70,11 @@ public: ...@@ -119,13 +70,11 @@ public:
void update(const PrimaryVariables &priVars, void update(const PrimaryVariables &priVars,
const Problem &problem, const Problem &problem,
const Element &element, const Element &element,
const FVElementGeometry &fvGeometry, const SubControlVolume &scv)
const int scvIdx,
const bool isOldSol)
{ {
Valgrind::CheckDefined(priVars); Valgrind::CheckDefined(priVars);
priVars_ = priVars; priVars_ = priVars;
extrusionFactor_ = problem.boxExtrusionFactor(element, fvGeometry, scvIdx); extrusionFactor_ = problem.boxExtrusionFactor(element, scv);
} }
/*! /*!
...@@ -164,9 +113,6 @@ public: ...@@ -164,9 +113,6 @@ public:
{ {
#if !defined NDEBUG && HAVE_VALGRIND #if !defined NDEBUG && HAVE_VALGRIND
Valgrind::CheckDefined(priVars_); Valgrind::CheckDefined(priVars_);
Valgrind::CheckDefined(evalPoint_);
if (evalPoint_ && evalPoint_ != this)
evalPoint_->checkDefined();
#endif #endif
} }
...@@ -176,9 +122,6 @@ protected: ...@@ -176,9 +122,6 @@ protected:
Implementation &asImp_() Implementation &asImp_()
{ return *static_cast<Implementation*>(this); } { return *static_cast<Implementation*>(this); }
// the evaluation point of the local jacobian
const Implementation *evalPoint_;
PrimaryVariables priVars_; PrimaryVariables priVars_;
Scalar extrusionFactor_; Scalar extrusionFactor_;
}; };
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment