Commit c209462f authored by Christoph Grueninger's avatar Christoph Grueninger
Browse files

[cleanup] Remove emtpy deconstructors, minor code cleanups.

(reviewed by nicolas)


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14373 2fb0f335-1f38-0410-981e-8018bf24f1b0
parent 289b229c
...@@ -26,15 +26,17 @@ ...@@ -26,15 +26,17 @@
#ifndef DUMUX_IMPLICIT_DARCY_FLUX_VARIABLES_HH #ifndef DUMUX_IMPLICIT_DARCY_FLUX_VARIABLES_HH
#define DUMUX_IMPLICIT_DARCY_FLUX_VARIABLES_HH #define DUMUX_IMPLICIT_DARCY_FLUX_VARIABLES_HH
#include "implicitproperties.hh"
#include <dune/common/float_cmp.hh> #include <dune/common/float_cmp.hh>
#include <dumux/common/parameters.hh>
#include <dumux/common/math.hh> #include <dumux/common/math.hh>
#include <dumux/common/parameters.hh>
#include "implicitproperties.hh"
namespace Dumux namespace Dumux
{ {
namespace Properties namespace Properties
{ {
// forward declaration of properties // forward declaration of properties
...@@ -74,7 +76,7 @@ class ImplicitDarcyFluxVariables ...@@ -74,7 +76,7 @@ class ImplicitDarcyFluxVariables
typedef typename FVElementGeometry::SubControlVolumeFace SCVFace; typedef typename FVElementGeometry::SubControlVolumeFace SCVFace;
public: public:
/* /*!
* \brief The constructor * \brief The constructor
* *
* \param problem The problem * \param problem The problem
...@@ -103,9 +105,8 @@ public: ...@@ -103,9 +105,8 @@ public:
* \brief Return the volumetric flux over a face of a given phase. * \brief Return the volumetric flux over a face of a given phase.
* *
* This is the calculated velocity multiplied by the unit normal * This is the calculated velocity multiplied by the unit normal
* and the area of the face. * and the area of the face. face().normal has already the
* face().normal * magnitude of the area.
* has already the magnitude of the area.
* *
* \param phaseIdx index of the phase * \param phaseIdx index of the phase
*/ */
...@@ -165,8 +166,8 @@ public: ...@@ -165,8 +166,8 @@ public:
} }
protected: protected:
/* /*!
* \brief Calculation of the potential gradients * \brief Calculation of the potential gradients
* *
* \param problem The problem * \param problem The problem
...@@ -180,7 +181,8 @@ protected: ...@@ -180,7 +181,8 @@ protected:
// loop over all phases // loop over all phases
for (int phaseIdx = 0; phaseIdx < numPhases; phaseIdx++) for (int phaseIdx = 0; phaseIdx < numPhases; phaseIdx++)
{ {
potentialGrad_[phaseIdx]= 0.0 ; potentialGrad_[phaseIdx]= 0.0;
for (unsigned int idx = 0; for (unsigned int idx = 0;
idx < face().numFap; idx < face().numFap;
idx++) // loop over adjacent vertices idx++) // loop over adjacent vertices
...@@ -227,7 +229,7 @@ protected: ...@@ -227,7 +229,7 @@ protected:
} // loop over all phases } // loop over all phases
} }
/* /*!
* \brief Actual calculation of the normal Darcy velocities. * \brief Actual calculation of the normal Darcy velocities.
* *
* \param problem The problem * \param problem The problem
...@@ -307,7 +309,7 @@ protected: ...@@ -307,7 +309,7 @@ protected:
+ (1.0 - mobilityUpwindWeight_)*downVolVars.mobility(phaseIdx)) ; + (1.0 - mobilityUpwindWeight_)*downVolVars.mobility(phaseIdx)) ;
// set the volume flux // set the volume flux
volumeFlux_[phaseIdx] = velocity_[phaseIdx] * face().normal ; volumeFlux_[phaseIdx] = velocity_[phaseIdx] * face().normal;
}// loop all phases }// loop all phases
} }
...@@ -325,4 +327,4 @@ protected: ...@@ -325,4 +327,4 @@ protected:
} // end namespace } // end namespace
#endif #endif // DUMUX_IMPLICIT_DARCY_FLUX_VARIABLES_HH
...@@ -64,9 +64,6 @@ public: ...@@ -64,9 +64,6 @@ public:
ImplicitLocalResidual() ImplicitLocalResidual()
{ } { }
~ImplicitLocalResidual()
{ }
/*! /*!
* \brief Initialize the local residual. * \brief Initialize the local residual.
* *
......
...@@ -70,10 +70,6 @@ public: ...@@ -70,10 +70,6 @@ public:
BoxCouplingLocalResidual() BoxCouplingLocalResidual()
{ } { }
//! \brief The destructor
~BoxCouplingLocalResidual()
{ }
/*! /*!
* \brief Compute the local residual, i.e. the deviation of the * \brief Compute the local residual, i.e. the deviation of the
* equations from zero. Gets a solution vector computed by PDELab * equations from zero. Gets a solution vector computed by PDELab
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment