Commit fbfa9bc2 authored by Timo Koch's avatar Timo Koch
Browse files

Merge branch 'feature/default-merge-request-template' into 'master'

Add merge request default template

See merge request !3113
parents ed6128e9 afedd010
Pipeline #17466 passed with stages
in 0 seconds
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/
**What this MR does / why does DuMux need it**:
**Which issue this MR fixes** *(optional - uncomment and add issue)*:
fixes #
**Special notes for your reviewer**:
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/
**What this MR does / why does DuMux need it**:
TODO: insert text here
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
**Notes for the reviewer**
TODO: insert text here
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in ``.
- [ ] is the list of the header includes complete? ("include what you use")
- [ ] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [ ] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [ ] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [``](
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see, the SOLID principles (, or the C++ Core Guidelines (
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment