Johannes Hommel authored 5 years ago and Theresa Schollenberger committed 5 years ago

[tests][2pncmin] corrected source term. Previously physically wrong, units did not balance. Updated reference

Bernd Flemisch authored 6 years ago and Kilian Weishaupt committed 6 years ago

Implement decision made in !1137:
- 1p gas: `gas`
- 1p liquid: `liq`
- 2p gas/liquid: `gas` and `liq`
- 2p liquid/liquid: `aq` and `napl`
- 3p: `gas`, `aq` and `napl`
- solid: `s`

Add `IsAqueous` to components to detect if a component is aqueous or not.
Adapt reference solutions.
Adjust `primaryVariableName` only where necessary to make the tests pass.
Will be treated in general in !1212.

This makes use of the introduced fluid state adapter for mapping to the right
phase and component indices.

This fixes:
- calculation of the liquid mixture density (for the case of it being composition-depent)
- make fugacity coefficient of NaCl zero (we assume NaCl to stay in the
water phase anyway throughout this fluid system)
- adapt reference solution

Sina Ackermann authored 6 years ago and Kilian Weishaupt committed 6 years ago

* consistent ordering of component/phase names: x^componentName_phaseName
* consistent use of underline: S_w, p_w, etc.
* change respective data field names in reference solutions

Katharina Heck authored 6 years ago and Timo Koch committed 6 years ago

[references][2pncminbox] update reference solution for saltflushbox after introduction of solidsystem

[2pncmin] beautification, new reference solution, changed to scalar permeability as setup is isotropic

- No mass fractions output
- Delete mass fractions, permeabilityFactor
  and rename velocity output for
  2pncmin reference solutions

* Old one did not account for changes in parameter names

* Old one did not account for changes in parameter names

Bernd Flemisch authored 8 years ago and Kilian Weishaupt committed 8 years ago

This concerns comments, output and local variable names.
Also fix some comments where liquid has been used instead of gas.

(cherry picked from commit cc2f9ee2)

This concerns comments, output and local variable names.
Also fix some comments where liquid has been used instead of gas.

for diffusion instead of concentration gradients.
This change was introduced in revision 0dc99b97
but the reference solution was not updated then.

* reference solution for box and cc changed after correcting liquidDensity function in commit 9757ac83
* reference solution for cc used wrong globalPos

Kilian Weishaupt authored 9 years ago and Thomas Fetzer committed 9 years ago

The old reference solution was obtained with brinevarsalinity
where an erroneous sign had not been corrected yet.

* Changed test problem to work with both discretizations
* Added a cell-centered test problem with reference solution
* Use new gridcreator
* The box reference solution lost the boxVolume data array
* Make variable switch work for cc

This commit contains backward imcompatible. All flux variables
now have to be default constructed. Implementers of flux variables
need to make their implementation default construcable too.
All calls to the old non-default ctors will throw errors at runtime and
emit deprecation warning at compile time. FluxVars are no constructed
and update like this:

FluxVariables fluxVars;
fluxVars.update(...)

Being default contructable offers more flexible class inheritance
and more flexible caching possiblities.

To this end especially the 2pnc/2pncmin flux variables where
updated to comform with other models. This involves some
deprecations. The 2pncmin reference had to be altered in the
velocity. The velocity was previously outputted wrongly as
the correct volumeFlux variable was never computed for 2pnc/2pncmin.

Reference solution for 2pncmin test is changed (Now solution for the last timestep and is used for comparison). 
The similation endtime is also reduced.

- REVIEWED BY J.HOMMEL

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15216 2fb0f335-1f38-0410-981e-8018bf24f1b0