Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

The fracture variables and matrix saturations have to be initialized
by default in case the return functions are used for vertices that are
not connected to a fracture

Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

Many of the private variables were not necessary for the performed
calculations.

Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

the porosity is already set in the base class

Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

for the update of the new fluid state the updated primary variables have to be used

Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

the fracture permeability in the volvars was not set. It is also not called yet which is why there was no segfault. However, one might want to have the possibility to call this function.

Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

After updating the matrix saturations in the interface condition the mobilities in the matrix have to be updated. This is essential in the dfm approach and was not implemented.

Dennis Gläser authored 9 years ago and Alexander Kissinger committed 9 years ago

in the local residual the derivative dSw_m/dSw_F was multiplied to the storage term even though in an implicit scheme this is not necessary

Update startmessage for 2.9; fix grammar



See merge request !111

Fix/forgotten renamings decoupled sequential



See merge request !108

Fixes the diffs.

[fix][generallensdecoupled] Conduct missing renaming decoupled->sequential

In the renaming process some files where forgotten which made the test fail.

See merge request !107

In the renaming process some files where forgotten which made the test fail.

Feature/remove continue

several cleanups

See merge request !101

[bugfix][electrochem] Use only static methods in static method



See merge request !105

[cornerpoint] Fix test and fluxvariables. Adapt to Opm 2015.10.

- Add a missing } in the test cc file.
- Add Dune::Geometries to CpFVElementGeometry.
- Fix the boundary transmissibilities.
- Change call to Opm parser routine to be compatible with Opm 2015.10.
- Adapt patches to Opm 2015.10.

See merge request !103

Feature/generalize 2pnc

* Adapt 2pnc to work with cell-centered too
* Add fuelcell cell-centered test
* Electrochemistry works without cubegridcreator
* Make more use of darcy flux variables
* Box test passed with old reference solution
* Adapt 2pncmin likewise

See merge request !80

[el2p] Adjust name of friend class



See merge request !104

Analogous to ImplicitDarcyFluxVariables.

- Add a missing } in the test cc file.
- Add Dune::Geometries to CpFVElementGeometry.
- Fix the boundary transmissibilities.
- Change call to Opm parser routine to be compatible with Opm 2015.10.
- Adapt patches to Opm 2015.10.

* Changed test problem to work with both discretizations
* Added a cell-centered test problem with reference solution
* Use new gridcreator
* The box reference solution lost the boxVolume data array
* Make variable switch work for cc

* Remove boxVolume from output
* Generalize static data vector handling
* Generalize problem method initialPhase presence
* Introduce reactionlayer
* Add reference solution for the cc test

* Make current density publicly available
* Use standard grid creator
* Implement reaction source term for box and cell-centered

Feature/make fluxvars default constructible

Make all flux variables default constructable.

This merge request contains backward imcompatible. All flux variables
now have to be default constructed. Implementers of flux variables
need to make their implementation default construcable too.
All calls to the old non-default ctors will throw errors at runtime and
emit deprecation warning at compile time. FluxVars are no constructed
and update like this:

FluxVariables fluxVars;
fluxVars.update(...)

Being default contructable offers more flexible class inheritance
and more flexible caching possiblities.

* Simplifiy 2pnc and 2pncmin flux variables through inheritance
* Deprecates the unused `rhoFactor_` in 2p2c, 2pnc, and 3p3c
* [x] Fix 2pncmin test

See merge request !89

Clang warned about && and || without parenthesis which might
confuse readers

* Remove empty constructor
* Remove wrongly included config.h which is only needed in cc files
* Remove else after return in if branch

Cleaned up version is easier to understand

Fix/3p parker vg



See merge request !97