Hanchuan Wu authored 4 years ago and Dennis Gläser committed 4 years ago

Upgrade the tests into a documented example with
verfication benchmark against published reference data.

* fixes compiler warning 'array subscript 2 is outside array bounds'
  for pseudo 3d case

Ned Coltman authored 4 years ago and Melanie Lipp committed 4 years ago

[rans] Introduce a struct for the wallElementinformation, change HasChannelGeometry to IsFlatWallBounded, fix maximum/minimum velocity names (remove profile, add comments), flowNormalAxis to flowDirectionAxis,  sandgrainroughness default.

Ned Coltman authored 4 years ago and Melanie Lipp committed 4 years ago

* Include non-  normal axis distances
* Cleanup wall and flow normal axis variables
* Include scvf corners as possible wall locations

Ned Coltman authored 4 years ago and Timo Koch committed 4 years ago

* Loads in solution from rans2c for a rans2cni test
* Tests rans2cni faster, plus loading a partial solution for ICs

Replace calls to deprecated `DUNE_VERSION_NEWER_REV(DUNE_ISTL,2,7,1)`
by `DUNE_VERSION_GT_REV(DUNE_ISTL,2,7,0)` which also reads better than
the `GTE` version, as Dune 2.7.1 hasn't been released yet. Fix the
call to `DUNE_VERSION_GT(DUNE_ISTL,2,7)` in the solver factory
backend which would break things in case of a 2.7.1 release. Adapt
the corresponding changelog entry.

This reverts commit 37c21581.

* replace outflow conditions by Neumann-noflow (closed boundaries assumed everywhere)