Variablesbackend does not support Dune::DynamicVector as Dof vector

Bug report The current variablesbackend does not consider the situation that the residual type in assembler in newtonsolver can be DynamicVector.

What happened / Problem description:

 /Applications/DUMUX/dumux/dumux/common/variablesbackend.hh:165:10: error: implicit instantiation of undefined template
      'Dumux::DofBackend<Dune::DynamicVector<double, std::__1::allocator<double> >, false>'
: public DofBackend<Vars>

Environment:

• Dune version:master
• DuMux version:master
• Others:The compiler is clang-1200.0.32.29, operation system is MacOS.

changed milestone to %3.4

added Bug Fix label

changed the description

can you tell me a specific test that doesn't compile on your machine so that I can check?

Nothing is forward declared here. It's just declared and then defined and specialized for all types it's supposed to work. A forward declaration would be a declaration without a definition immediately following. Maybe some include is missing?

@hanchuan But yeah more importantly, what are you compiling?

do you think it may be because we forward declare MultiTypeBlockMatrix? So @hanchuan, I was supposing you compiled a multidomain test - is that so?

and please update the description with the actual error and not what you interpreted from it.

I see the logics here. Actually I thought it would be a general problem, but I just find it is only for our 2d_kernel case, then I find that it is in our analyticalsolution.hh. At least I think the using NewtonSolver = Dumux::NewtonSolver<Assembler, LinearSolver, DefaultPartialReassembler>; might not be considered. But now I am trying to reproduce it with a test case in dumux.

I think that case uses DynamicVector right? And the Backend doesn't have a specialization for that yet?

Yes! You are right, so as a result, the compiler returns the following error:

 /Applications/DUMUX/dumux/dumux/common/variablesbackend.hh:165:10: error: implicit instantiation of undefined template
      'Dumux::DofBackend<Dune::DynamicVector<double, std::__1::allocator<double> >, false>'
: public DofBackend<Vars>

@DennisGlaeser before merging the backend and seemed to have worked to use any vector that has certain operations defined. So maybe we should implement a default dofbackend which is the same as the blockvector specialization (then obsolete).

@hanchuan Please update the issue description for documentation purposes!

@timok The problem for that is that the test case is not in our dumux repo, I did not find a case in dumux repo which has the same problem yet.

Then properly describe what it does!

@timok, yeah sounds good. So the default (for non-scalars) would be that we expect that the type has resize, axpy, size and is default-constructible.

are you on it? Otherwise I would try.

Nevermind, I just saw you did it already.

changed the description

mentioned in merge request !2564 (merged)

added Bug Report label and removed Bug Fix label

removed Bug Report label

changed the description

closed with merge request !2564 (merged)

mentioned in commit e954822c

changed title from implicit instantiation of undefined template in Variablesbackend to Variablesbackend does not support Dune::DynamicVector as Dof vector