FS#261 Misnomer evalPhaseStorage in couplinglocalresiduals
|Reported by||Bernd Flemisch (firstname.lastname@example.org)|
|Reported at||Apr 15, 2015 08:54|
|Last edited by||Bernd Flemisch (email@example.com)|
|Last edited at||May 28, 2015 10:41|
|Closed by||Bernd Flemisch (firstname.lastname@example.org)|
|Closed at||May 28, 2015 10:41|
|Closed in version||2.8|
The 2p2c(ni) couplinglocalresiduals have a member function named "evalPhaseStorage". However, not the storage "S" is calculated there, but its time derivative "(S_new - S_old) / dt". This is not only a misnomer, but also inconsistent with the uncoupled 2p2c localresidual that offers a function with the same name that really calculates "S".
I would propose to rename the function to "evalPhaseStorageDerivative".