FS#329 Suspicious calculation in air's gasViscosity
Metadata
Property | Value |
---|---|
Project | dumux |
Category | Material framwork |
Reported by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
Reported at | Sep 15, 2016 12:29 |
Type | Bug Report |
Version | 2.9 |
Description
in dumux/material/components/air.hh:134 the dipole moment is set to 0. This leads to a pointless (probably optimized away) calculation of mu_r4. Either we remove the computation or fix the value of the dipole moment.
This error is with us since the initial creation of the file in 2012
Code excerpt: const Scalar dipole = 0.0; // dipole moment [debye]
Scalar mu_r4 = 131.3 * dipole / std::sqrt(Vc * Tc); mu_r4 *= mu_r4; mu_r4 *= mu_r4;
Scalar Fc = 1 - 0.2756omega + 0.059035mu_r4;