Thomas Fetzermarked the task Update documentation as incomplete
marked the task Update documentation as incomplete
Thomas Fetzermarked the task Implement static_assert(useMoles || numComp < 3) as incomplete
marked the task Implement static_assert(useMoles || numComp < 3) as incomplete
Thomas Fetzermarked the task Fick's law will always be mole based (as in its derivation). However, the fluxes are transformed into mass fluxes if useMoles = false as incomplete
marked the task Fick's law will always be mole based (as in its derivation). However, the fluxes are transformed into mass fluxes if useMoles = false as incomplete
Thomas Fetzermarked the task When useMoles = false we will have to add the diffusive fluxes to the total mass balance equation (eqIdx = replaceCompIdx) as incomplete
marked the task When useMoles = false we will have to add the diffusive fluxes to the total mass balance equation (eqIdx = replaceCompIdx) as incomplete
Katharina Heckmarked the checklist item Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it as completed
marked the checklist item Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it as completed
Katharina Heckmarked the checklist item Fick's law will always be mole based (as in its derivation). However, the fluxes are transformed into mass fluxes if useMoles = false as completed
marked the checklist item Fick's law will always be mole based (as in its derivation). However, the fluxes are transformed into mass fluxes if useMoles = false as completed
Return vector of fluxes from fick's law is not implemented? There seems to be an open, yet un-merged branch concerning this issue. This would also fix the bug of the forgotten density on the box Fick's law.
Timo Kochmarked the checklist item Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it as incomplete
marked the checklist item Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it as incomplete
Kilian Weishauptmarked the checklist item Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it as completed
marked the checklist item Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it as completed
Kilian Weishauptmarked the checklist item When useMoles = false we will have to add the diffusive fluxes to the total mass balance equation (eqIdx = replaceCompIdx) as completed
marked the checklist item When useMoles = false we will have to add the diffusive fluxes to the total mass balance equation (eqIdx = replaceCompIdx) as completed
I do not think we need the static_assert and I cannot remember why we wanted it? All calculations are now one molar basis so I guess this is obsolete now? As for the documentation, we might need to update that a bit but it should not be too much. We should be able to finish that on Wednesday