Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 91
    • Issues 91
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Issues
  • #443
Closed
Open
Created Feb 08, 2018 by Timo Koch@timokOwner

Make the difference between stationary and instationary problems more obvious

Currently the assembler constructor decides whether a stationary or an instationary problem is assembled. This hides this feature a bit as there is only a difference in the arguments and no error if used inside a timeloop. Different classes might make it more obvious, but might be a bit more code to implement.

  • Suggestion 1: Make error messages better and provide a terminal message what type of problem the assembler is assembling
  • Suggestion 2: Two different classes: The InstationaryAssembler could probably inherit almost everything from the StationaryAssembler, or both inherit from either only the assembler base class or from both assembler and an instationary assembler base class.
Edited Feb 08, 2018 by Timo Koch
Assignee
Assign to
Time tracking