Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #670
Closed
Open
Issue created Mar 05, 2019 by Kilian Weishaupt@kweisOwner0 of 1 checklist item completed0/1 checklist item

[md][stokesdarcy] Upwinding of component enthalpy is probably wrong

const bool insideDiffFluxIsUpstream = std::signbit(diffusiveFlux[domainICompIdx]);

should probably be

const bool insideDiffFluxIsUpstream = diffusiveFlux[domainICompIdx] > 0.0;
  • Furthermore, we should check if all fluidsystems implement componentEnthalpy.
Edited Mar 05, 2019 by Kilian Weishaupt
Assignee
Assign to
Time tracking