Dune 2.6 and Dune 2.7 compatible with dumux 3.2?

changed milestone to %3.2

I currently don't see a reason for requiring 2.7 only. Everything should still run with 2.6. @timok It seems that we currently test only against Dune master and Dune 2.7. Is it too much hassle to test also against Dune 2.6? If not, we should allow depending on 2.6 and test for it, until it becomes a too large burden.

Regardless of this, the scripts and instructions should indeed be updated such that 2.7 is the default.

I guess it is actually testing against 2.6. For the release I think, we can keep 2.6 because now everything still works with dune 2.6. For after the release I would require Dune 2.7 immediately so that we don't even need to check against two dune versions which is quite a hassle. For the CI I guess I would only test 3.2 against 2.6 and test 3.3-git against 2.7 and master. Otherwise we have quite a lot of tests. They already run so long. We currently test

Dune:	2.5	2.6	master
Dumux master		x	x
Dumux 3 (latest release 3.0)		x
Dumux 2 (latest release 2.12)	x

After the release, we could do

Dune:	2.5	2.6	2.7	master
Dumux master			x	x
Dumux 3 (latest release 3.2)		x	x
Dumux 2 (latest release 2.12)	x

What do you think? That would be two more builds.

We could also drop testing Dumux 2.12, do we still do bugfix support for 2.12?

changed title from Dune 2.7 required for dumux 3.2 to Dune 2.7 required for dumux 3.2?

Your plan sounds good. I also think that we can drop 2.12 testing and support once 3.2 is out.

Ok, I updated the issue description accordingly

changed the description

changed title from Dune 2.7 required for dumux 3.2? to Dune 2.6 and Dune 2.7 compatible with dumux 3.2?

assigned to @timok

mentioned in issue #833 (closed)

mentioned in issue #829 (closed)

mentioned in merge request !1997 (merged)

After release 3.2 add note to the change log that 2.12 is no longer supported and write email to users

@bernd Would you write that email and close this issue?

closed via merge request !1997 (merged)

mentioned in commit 9b6830e4

marked the checklist item After release 3.2 increase dependency to Dune 2.7 as completed

We still need to address the first todo.

reopened

Shouldn't we also try to keep the 3.2 release branch working with Dune master?

I don't think so. Did we do that in the past?

According to the dumux-release manager notes, yes. But I've made a ton of changes to that, a bunch of stuff was way outdated.

But then the release branch would never be stable because you might have to update it if something changes in the dune master. Seems weird to me to support a future unstable version of a dependency as well.

I kind of agree. Here's the referenced text from the guide:

Use an alternative DuMux folder with the master versions of the Dune modules so that it is ensured that the release also works with them. There will likely be a bunch of complier warnings here, but that is alright for the dune-master case.

I guess it must mean the release should work with dune master at the release date.

Something like this would make more sense to me: Highest priority: 2.6 and 2.7. If possible, master?

Something like this would make more sense to me: Highest priority: 2.6 and 2.7. If possible, master?

yeah that makes sense

I agree. I didn't mean that we should stay compatible with master by all means. But it would be good to know at least when it breaks.

Why is it important when it breaks? Then we would need another BuildBot testing dumux 3.2 with dune master although we actually don't require that they are compatible. It's a lot of extra (computational) work. There are probably other configurations, like different compilers, that are more important to test.

Isn't the point it breaks the same time as Dumux master & Dune master break? If everything is perfectly backwards-compatible in Dune, then Dumux 2.7 should also work with Dune 2.8, right?

Ok.

After release 3.2 add note to the change log that 2.12 is no longer supported and write email to user

update changelog (push to master but NOT to release/3.2)
write email to users to describe this information (Should we include this in the release announcement email?)

@bernd Can you write the email that we drop support and automated testing for Dumux 2?

mentioned in merge request !2116 (merged)

mentioned in commit 15793911

changed the description

marked the checklist item Write email to users about above. as completed

closed

Dune 2.6 and Dune 2.7 compatible with dumux 3.2?

Designs

Child items 0

Activity