Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !1315

[component] Remove defaults from constant component

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge feature/remove-contant-component-defaults into master Nov 21, 2018
  • Overview 7
  • Commits 2
  • Pipelines 0
  • Changes 50

Fix #579 (closed) where is was noted that 1.0 as default is more a disadvantage than an advantage. Just specify 1.0 in the input file explicitly instead. For examples typos in the input files could be unnoticed.

  • Remove the default for constant component
  • Do not set molar density if it's not used and not returned in any interface (fixes #608 (closed))
  • Do not output molar density in navierstokes non-compositional models (fixes #608 (closed)), adjust references (remove rhoMolar)
  • Fuelcellni test had the wrong solid phase properties -> fixed parameters and adjusted reference solution
  • Sagd test had a typo in the input file -> fixed typo and adjusted reference solution
Edited Nov 24, 2018 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/remove-contant-component-defaults