Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 85
    • Issues 85
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !1713

Merged
Created Sep 06, 2019 by Simon Emmert@emmertMaintainer

[fluidsystem][test] add forgotten fluidsystems to test, fix fluidsystems

  • Overview 3
  • Commits 1
  • Changes 3

What this MR does / why does DuMux need it: Adds forgotten fluidsystems to the fluidsystems-test.

This leads to small changes in the 3pimmiscible fluidsystem as well as some restructuring of the H2OHeavyOil fluidsystem. The H2OHeavyOil was adapted to match a 2c-fluidsystem which implements a binary diffusion coefficient. So far only the diffusion coefficient was implemented, but actually the binary diffusion coefficients without any changes were used. After discussion with @bernd we decided to move it to the binaryDiffusionCoefficient(), but for the sake of compatibility keep the diffusionCoefficient() which makes use of the new binaryDiffusionCoefficient().

Special note: I was not able to get the liquidphase2c running with the fluidsystems test, as it assumes a "constant"-component that gets values from the input file. The code compiles, but fails during execution because there is not input file. I have three possible solutions in mind, but maybe @bernd has a good idea:

  1. Create a "unit"-component. This would be a (specialization of the) constant component where everything is set to "1". It would be similar to what we had with the default values in the constant component before.
  2. Do not test the liquidphase2c fluidsystem
  3. Paramters::init() was used to mimic an input-file
Edited Sep 12, 2019 by Simon Emmert
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/fluidsystems-test