Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !1716

WIP: Feature/explicit flashs of compositional models

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Beatrix Becker requested to merge feature/explicit-flashs-of-implicit-models into master Sep 19, 2019
  • Overview 26
  • Commits 10
  • Pipelines 0
  • Changes 31

What this MR does / why does DuMux need it: Introduces a 2p2c-specific constraint solver, that explicitly calculates mass fractions for two-phase state, assuming ideal mixtures (as does the generic mpnc constraint solver for two-phase state). Changes in volumevariables: The new constraint solver is used for two-phase state. In the one-phase state the ComputeFromReferencePhase solver is used, since it does the simplest thing possible for ideal mixtures. useConstraintSolver is deleted because it's not needed anymore.

Resolves #761

Special notes for your reviewer: Is it okay to have a new header for the 2p2c-specific constraint solver or should I integrate it as a special case in the generic one? I guess this is not backward compatible (deleted useConstraintSolver)? Do I have to deprecate the entire old volumevariables? @holle : The 2p2c tests parse with the new constraint solver (they did so before with the old, in my opinion slightly less correct/buggy version, too, although that was never tested...). Does it look good to you, too?

Edited Jun 01, 2022 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/explicit-flashs-of-implicit-models