Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !1807

[vangenuchten] Introduce pore-connectivity parameter L

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge feature/introduce-vangenuchtem-mualem-param-l into master Nov 22, 2019
  • Overview 5
  • Commits 10
  • Pipelines 0
  • Changes 37

What this MR does / why does DuMux need it: Introduces the pore-connectivity parameter l. The parameter is used in the relative permeability curve in the Mualem model. Mualem (1976) suggested that 0.5 is a good value for many soils. Sometimes a value different from 0.5 is provided, which is why this patch implements it as additional variable.

Special notes for your reviewer:

  • There was something weird in krn. The function uses the factor (1-S_{we})^{1/3} but according to the van Genuchten Mualem model this should be (1-S_{we})^{1/2} or (1-S_{we})^l. See Mualem 1976 (https://doi.org/10.1029/WR012i003p00513) and e.g. Dury et all (1999) (https://doi.org/10.1029/1999WR900019). @holle The 1/3 appears e.g. in your habilitation but no other sources than Mualem and van Genuchten are given. Can you comment on where it might come from?

  • I believe the derivative \frac{\partial k_{rn}}{\partial S_{we}} was wrong. Please recheck the new result before merging.

These two points change the van genuchten material law (not backwards compatible) and could also result in differences in the reference solutions. If the changes get accepted we should

  • Add note in changelog about the changes in vangenuchten
  • Check tests and possibly update references
Edited Feb 01, 2020 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/introduce-vangenuchtem-mualem-param-l