Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !1821

[WIP][md] Implement box staggered coupling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kilian Weishaupt requested to merge feature/box-staggered-coupling into master Dec 12, 2019
  • Overview 13
  • Commits 69
  • Pipelines 17
  • Changes 80

Todos:

  • Add test for segment-segment intersection algorithm
  • Make segment-segment intersection algorithm more efficient
  • Put segment-segment in different MR
  • Extract Box-Forchheimer to separate MR
  • New BJ test (existing test uses indefinite perm. matrix)
  • Change convergence script to specify convergence rate
  • It currently only works for DiffusionCoefficientAveragingType::ffOnly
  • Maxwell Stefan Diffusion law not yet implemented when using Box
  • Renaming: Use ff/pm instead of stokes/darcy
  • New IC assume specific parameter group "Darcy", generalise this
  • Add missing tests

Suggestions:

  • Currently, we retrieve the entire context via couplingContextVector(), but the old interface is still there. I would shrink this to only one interface and probably rename it. Currently, there is one context object per coupling segment, so maybe we can find a better name.
  • At the moment the coupling segment geometry is stored in both the darcy and the stokes coupling info objects in the mapper. I don't think this is the most memory consuming part of the code, but there is room for memory efficiency improvements.

Fixes #788 (closed).

Edited Oct 07, 2021 by Martin Schneider
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/box-staggered-coupling