Skip to content

Cleanup/parametercompare

Ned Coltman requested to merge cleanup/parametercompare into releases/3.2

The release guidelines say that we should run and address the issues mentioned in bin/doc/compareparameters.sh.

The script searches for all of the runtime params in the version we have, and then compares it to an oldparameters.txt list.

The script doesn't work so well with some variations (line splits, separate paramgroup arguments).

I manually went through the "added" files and made changes to the parameters.txt file.

I copied all of the output from the deleted section and ran that them through this check:

runcheck () {
if grep -q -nriI "$1" test;
then
    continue
else
    if grep -q -nriI "$1" dumux;
    then
        continue
    else
        echo $1 NOT Found
    fi
fi
}

two subgrid based grid parameters could be removed.

I also tried to remove duplicates, and adjust modified a few lowercase mpfa calls.

I don't really know what the goal of this is. Doxygen? @emmert, @heck, @timok does this make sense at all? It seems like you guys have looked at this before based on the history.

Not really sure what else should be done here.

Edited by Ned Coltman

Merge request reports