Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2051

Fix tests that fail with minimal setup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Emmert requested to merge fix/minimal-conduction-tests into master Apr 24, 2020
  • Overview 42
  • Commits 2
  • Pipelines 0
  • Changes 3

What this MR does / why does DuMux need it: Fixes the failing tests (1pni and 3pni for now) by using a fixed increment timestep and lower DtInitial for the tpfa-test. I went for changing the DtInitial in the CMakeLists.txt instead of putting it in the input file. If we think it is better to change the params.input, and by this achieve the same amount of vtk-outputs for tpfa and box, we can also do that.

Which issue this MR fixes: fixes #871 (closed)

Special notes for your reviewer: I have the 1pni version not ready yet as the other tests are also affected by the fixed timestep increment. I will get back to it and push the rest after my Bernd-Meeting... I have not made any progress on the 2p-test so far.

Edited Apr 29, 2020 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/minimal-conduction-tests