Skip to content

GitLab

dumux
dumux
Merged
Opened by Timo Koch@timok4 of 4 tasks completed4/4 tasks
Report abuse

Feature/simplify staggered upwind fluxvars

Simplifies the upwind flux vars. Is based on !2168 (merged) so that MR should be merged first.

@nedc @kweis There is a bugfix in the last commit. I'm not sure if this is correct and when the case exactly occurs. The kovasznay tests pass.

TODO

  • Rename upwind header
  • static_assert that higher order only works with caching enabled (different MR)
  • Add TODO note that higher order is only higher order for incompressible flow (different MR)
  • static_assert that only up to second order upwinding is implemented

@nedc @kweis Also something seems to be wrong with the densities in the lateral upwind momentum. First order uses once inside once outside (here !2169 (diffs)), higher order uses always inside (here !2169 (diffs)) or outside for the density.

Edited by Timo Koch