Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !2169

Feature/simplify staggered upwind fluxvars

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge feature/simplify-staggered-upwind-fluxvars into master Jun 03, 2020
  • Overview 40
  • Commits 8
  • Changes 5

Simplifies the upwind flux vars. Is based on !2168 (merged) so that MR should be merged first.

@nedc @kweis There is a bugfix in the last commit. I'm not sure if this is correct and when the case exactly occurs. The kovasznay tests pass.

TODO

  • Rename upwind header
  • static_assert that higher order only works with caching enabled (different MR)
  • Add TODO note that higher order is only higher order for incompressible flow (different MR)
  • static_assert that only up to second order upwinding is implemented

@nedc @kweis Also something seems to be wrong with the densities in the lateral upwind momentum. First order uses once inside once outside (here !2169 (diffs)), higher order uses always inside (here !2169 (diffs)) or outside for the density.

Edited Jun 08, 2020 by Timo Koch
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/simplify-staggered-upwind-fluxvars