Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 102
    • Issues 102
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2227

WIP: Feature/new ic condition2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Lars Kaiser requested to merge feature/new-ic-condition2 into feature/box-staggered-coupling Aug 05, 2020
  • Overview 8
  • Commits 40
  • Pipelines 0
  • Changes 17

What this MR does / why does DuMux need it: This MR implements new coupling conditions for stokes-darcy interfaces, as proposed/described by Elissa Eggenweiler. The new interface conditions are meant to be more general and appropriate in comparison to the Beavers-Joseph condition and the current normal momentum coupling.

TODO:

  • Combine new/standardPorousMediumVelocity, beaversJoseph/nTangentialVelocity and old/newMomentumCouplingCondition
  • Allow unsymmetrizedStressTensorForBJ and unsymmetrizedStressTensorForIC!
  • Set up two tests: Beaver-Josephs and newIC, see: dumux/test/multidomain/boundary/stokesdarcy/1p_1p, @Elissa
  • Check deprecation and documentation, link to paper from Elissa?
  • Add warning for newIC with symmetrized tensor
  • Folder and file names should not contain capital letters.
  • Follow styleguide: Correct indent, curly braces
  • Small TODOs in project

Special notes for your reviewer: I appreciate all help regarding the technicalities of the merge request.

Edited Sep 22, 2020 by Lars Kaiser
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/new-ic-condition2