[shallowwater][diffusion] add turbulent diffusion to shallow water
-
Review changes -
-
Download -
Patches
-
Plain diff
Adding (turbulent) diffusion to the shallow water model (part of freeflow):
The implementation basically contains three parts:
- computation of a horzontal diffusion flux (shear stress)
- computation of possible wall-shear stress
- computation of a turbulent viscosity from a very basic turbulence model (mixing-length based, kept as local as possible)
For now using either a constant eddy-viscosity (turbulence model 0) or a horizontal mixing-length based appraoch (turbulence model 1). Other turbulence models might be added in later. The implementation contains 2 wall shear stress implementations:
- no-slip implementation
- law-of-the-wall implementation
One test has been added: Poiseuille flow test: for flow in a channel with rough side walls. This test has an analytical solution.
Which issue this MR fixes Fixes #706 (closed)
Special notes for your reviewer: The Poiseuille flow test only tests two of the three added functionalities: the horizontal diffusion and the wall shear stress implementations, with constant eddy viscosity. The turbulence model 1 implementation where the eddy viscosity is computed algebraically based on the local bottom shear stress and velocity gradients is not tested in this test case. A number of test cases was, however, performed to test this. Among others, a test case for the flow around a thin wall. Should this test also be added? Moreover, the present Poiseuille test uses a structured rectangular grid. The same test was also set up and performed on an unstructured triangular grid. Is this test also required? Thank you very much!
Merge request reports
- version 29b7ffcc0a
- version 28e218d002
- version 274f3e392f
- version 26cac73f46
- version 25bf3e4cbe
- version 24cb391927
- version 23a991c18c
- version 2229639e15
- version 214f6895b2
- version 200369e7fc
- version 19986e7dcd
- version 1813d09499
- version 178da9c5eb
- version 16a7734ce3
- version 15f690fb42
- version 14aee5c82f
- version 13ac08cdad
- version 123551a700
- version 115927b814
- version 10e7c16c3d
- version 99ff54229
- version 80b7bf2cf
- version 764a933c1
- version 6413ec5ef
- version 5cc30d722
- version 466e887a3
- version 30f7e92ca
- version 299fe69f5
- version 1a0cd35a5
- master (base)
- latest version2ca3eb553 commits,
- version 29b7ffcc0a3 commits,
- version 28e218d0022 commits,
- version 274f3e392f6 commits,
- version 26cac73f465 commits,
- version 25bf3e4cbe2 commits,
- version 24cb3919271 commit,
- version 23a991c18c1 commit,
- version 2229639e1527 commits,
- version 214f6895b226 commits,
- version 200369e7fc25 commits,
- version 19986e7dcd23 commits,
- version 1813d0949922 commits,
- version 178da9c5eb21 commits,
- version 16a7734ce319 commits,
- version 15f690fb4217 commits,
- version 14aee5c82f16 commits,
- version 13ac08cdad15 commits,
- version 123551a70013 commits,
- version 115927b81412 commits,
- version 10e7c16c3d11 commits,
- version 99ff5422910 commits,
- version 80b7bf2cf9 commits,
- version 764a933c18 commits,
- version 6413ec5ef7 commits,
- version 5cc30d7226 commits,
- version 466e887a34 commits,
- version 30f7e92ca3 commits,
- version 299fe69f52 commits,
- version 1a0cd35a51 commit,
- Side-by-side
- Inline