Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 92
    • Issues 92
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !2307

[bugfix][cc][scv] Replace optional by unique_ptr

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge fix/cc-subcontrolvolume into master Oct 27, 2020
  • Overview 6
  • Commits 1
  • Changes 1

Using optional lead to issues probably because the assignment operator were not correcty implemented. However there is not need for optional here since the member is in fact not optional but always there when the object is validly constructed. We can simply use a unique_ptr to work around the fact that not all geometry imeplementation are default-constructible and/or copy-assignable.

Fixes #930 (closed).

Should be also backported to release 3.2 since the bug already occurred there but hasn't been detected by the CI.

Edited Oct 27, 2020 by Timo Koch
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/cc-subcontrolvolume