Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 91
    • Merge requests 91
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !2458

fix the failing Richards benchmark test

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Hanchuan Wu requested to merge feature/fix-failing-richards-benchmark-test into master Jan 28, 2021
  • Overview 10
  • Commits 1
  • Changes 8

The problem is figured out. Because the VanGenuchtenPcHighSweThreshold and VanGenuchtenKrwHighSweThreshold are set to 1.0, which failed the assert check assert(x_(i) > x_(i-1)) (line 636 in dumux/common/splinecommon_.hh) by assigning x_(i) and x_(i-1) both to 1. The simplest way to solve it is easily set SweThreshold to some value close to 1 like 0.99999, (0.9999 is still not enough precise for infiltration case). In the end, we need to enlarge TIMEOUT, otherwise it fails too.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/fix-failing-richards-benchmark-test