Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 94
    • Merge requests 94
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2458

fix the failing Richards benchmark test

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Hanchuan Wu requested to merge feature/fix-failing-richards-benchmark-test into master Jan 28, 2021
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 8

The problem is figured out. Because the VanGenuchtenPcHighSweThreshold and VanGenuchtenKrwHighSweThreshold are set to 1.0, which failed the assert check assert(x_(i) > x_(i-1)) (line 636 in dumux/common/splinecommon_.hh) by assigning x_(i) and x_(i-1) both to 1. The simplest way to solve it is easily set SweThreshold to some value close to 1 like 0.99999, (0.9999 is still not enough precise for infiltration case). In the end, we need to enlarge TIMEOUT, otherwise it fails too.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/fix-failing-richards-benchmark-test