Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2473

WIP: [material][constant] Put volume work energy into storage term / internal energy

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Timo Koch requested to merge fix/enthalpy-constant-component into master Feb 08, 2021
  • Overview 38
  • Commits 1
  • Pipelines 0
  • Changes 1

Harmonize enthalpy/internal energy of Constant component with the SimpleH2O implementation.

This is how it's done in SimpleH2O.

@holle Can you comment on this? Numerically it seems to make a difference if the consitutive law, i.e. dh = du + pdv is inserted for u or for h. It seems to me easier to account for the volume work in the volume integral.

As this has been only recently introduced in master !2421 (merged)/!2423 (merged) we can still change it easily.

Edit/Update: Constant component seems to be correct and SimpleH2O is the one that has a bug (wrong enthalpy and thus internal energy). So we shouldn't merge this but fix SimpleH2O instead.

Edited Feb 18, 2021 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/enthalpy-constant-component