Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 84
    • Issues 84
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !2736

Merged
Created Jul 28, 2021 by Ned Coltman@nedcMaintainer9 of 9 tasks completed9/9 tasks

Feature/simplify local view

  • Overview 201
  • Commits 11
  • Changes 121

Fixes #1060 (closed)

  • Make sure I'm even doing this correctly

  • Change bind interface for each discretization's fvelementgeometry.hh

  • Change bind interface for each ELemVolVars

  • Change bind interface for each FluxCache

  • Go through all dumux/ headers and replace useage

  • Go through all test/ headers and replace useage

  • Add a note to the change log

  • Perform Benchmark to evaluate cost localview call within or outside of a element loop

  • Make changes according to the Benchmark results:

Policy here:

1.) If bind(element) is called within an element loop, call auto fvGeometry = localView(gridGeometry) before the loop.

2.) If bind(element) is only called once (e.g. in certain functions), use the convenience syntax.

Edited Aug 16, 2021 by Timo Koch
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/simplifyLocalView