Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2736

Feature/simplify local view

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ned Coltman requested to merge feature/simplifyLocalView into master Jul 28, 2021
  • Overview 201
  • Commits 11
  • Pipelines 20
  • Changes 121

Fixes #1060 (closed)

  • Make sure I'm even doing this correctly

  • Change bind interface for each discretization's fvelementgeometry.hh

  • Change bind interface for each ELemVolVars

  • Change bind interface for each FluxCache

  • Go through all dumux/ headers and replace useage

  • Go through all test/ headers and replace useage

  • Add a note to the change log

  • Perform Benchmark to evaluate cost localview call within or outside of a element loop

  • Make changes according to the Benchmark results:

Policy here:

1.) If bind(element) is called within an element loop, call auto fvGeometry = localView(gridGeometry) before the loop.

2.) If bind(element) is only called once (e.g. in certain functions), use the convenience syntax.

Edited Aug 16, 2021 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/simplifyLocalView