Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2792

[test][freeflow] Improve error calculation.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Melanie Lipp requested to merge feature/freeflowErrors into master Aug 25, 2021
  • Overview 38
  • Commits 7
  • Pipelines 22
  • Changes 26
  • Change of the calculation of the L2 error: The calculation of the L2 error before built the four vectors staggeredVolume, errorVelocity, velocityReference and directionIndex. There where two loops: one filling those vectors, one using them. The reason for this approach was that for the staggeredVolume the two staggeredHalfVolumes corresponding to two different scvfs have to be added.

    This MR changes the error calculation to one loop making use of the fact that both staggeredHalfVolumes are multiplied by the same factor errorVelocity[i]. So building the four vectors staggeredVolume, errorVelocity, velocityReference and directionIndex is avoided.

  • Adding a calculation of an L infinity error

  • Move printError out of individual test files to one common file.

  • Change error output format to a CSV file

ToDos

Manually make sure L2 errors are unchanged on a sample basis:

  • Angeli
  • Channel 1d

Deal with following files:

  • test/freeflow/navierstokes/convergence.sh
  • test/freeflow/navierstokes/channel/pipe/convergencetest.py
  • test/freeflow/navierstokes/sincos/convergencetest.py
Edited Aug 31, 2021 by Melanie Lipp
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/freeflowErrors