Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !2897

[splinecommon_] Wrong index variable and other fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christoph Grüninger requested to merge feature/fix-splinecommon_.hh into master Oct 22, 2021
  • Overview 4
  • Commits 3
  • Pipelines 3
  • Changes 1

assignSamplingPoints_, assignFromArrayList_, and assignFromTupleList_ contain the same bug, it uses the wrong index variable i instead of idx. As these functions are never used, this never has been a problem. I propose to get rid of them, as they are internal and unused.
In case you want to keep them, this MR might be helpful, but someone should write tests for these three functions.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/fix-splinecommon_.hh