Freeflow Model Spatial Params
Merge request reports
Activity
mentioned in merge request !2930
added 8 commits
- 46b43065 - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- 19338881 - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 8943e5c6 - [freeflow] update all extrusion factor calls to the spatialParams
- e29d7f05 - [pmf][1pconstant] fix naming of the 1p constant spatialparams
- 9c0bcc43 - [test][richards] update spatial params
- 941515b8 - [test] shallow water tests update to new spatial parameters
- c5387213 - [test][discretization] use new spatial params
- eb911627 - [test][2pncmin] use new spatial params interface
Toggle commit listadded 9 commits
- 32a755ae - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 69729a7b - [freeflow] update all extrusion factor calls to the spatialParams
- 746013c5 - [pmf][1pconstant] fix naming of the 1p constant spatialparams
- b829bacb - [test][richardsnc] update spatial params
- 336c7032 - [test] shallow water tests update to new spatial parameters
- f78df1a7 - [test][discretization] use new spatial params
- 286af0a4 - [test][2pncmin] use new spatial params interface
- 6a0a1f50 - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- 9186ea8a - [test][multidomain][stokesdarcy] Update tests to new spatial params
Toggle commit list- Resolved by Ned Coltman
@DennisGlaeser @bernd, I was hoping to include the spatial params aspect into the new RANS implementation, so I started adding the spatial params stuff to the freeflow models. This is based in
feature/base-spatialparams-v2
, and could be merged into that branch/MR !2888 (merged).I ended up correcting a bunch of other warnings and errors in other tests, and those changes are listed here too. Unfortunately this still doesn't pass the pipeline to master, the 1p_pointsources_timedependent/independent tests are failing with a fieldvector based runtime error. Even more unfortunately, I can't reproduce this on my machine. I'm not sure if they passed on
feature/base-spatialparams-v2
, but I also don't think I did anything that would effect them?
added 91 commits
-
9186ea8a...55cbd0f4 - 82 commits from branch
feature/base-spatialparams-v2
- 33338631 - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- b63004ae - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 2388efff - [freeflow] update all extrusion factor calls to the spatialParams
- 6af1ba48 - [test][richardsnc] update spatial params
- 712fffec - [test] shallow water tests update to new spatial parameters
- 8e0cfaa9 - [test][discretization] use new spatial params
- 26d3e415 - [test][2pncmin] use new spatial params interface
- fb41b205 - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- 39f79c8c - [test][multidomain][stokesdarcy] Update tests to new spatial params
Toggle commit list-
9186ea8a...55cbd0f4 - 82 commits from branch
mentioned in merge request !2888 (merged)
added 84 commits
-
39f79c8c...3ed7edf2 - 75 commits from branch
feature/base-spatialparams-v2
- c84184fb - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- a960bccf - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 344e342e - [freeflow] update all extrusion factor calls to the spatialParams
- 07ceee21 - [test][richardsnc] update spatial params
- c09b2859 - [test] shallow water tests update to new spatial parameters
- 2c8f782e - [test][discretization] use new spatial params
- fc96217e - [test][2pncmin] use new spatial params interface
- 18c1b5af - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- da5b55c0 - [test][multidomain][stokesdarcy] Update tests to new spatial params
Toggle commit list-
39f79c8c...3ed7edf2 - 75 commits from branch
assigned to @DennisGlaeser
added 1 commit
- 02f1b4e5 - [test][multidomain][freeflowporenetwork] Update test to include the extrusion...
added 64 commits
-
02f1b4e5...3feb301e - 57 commits from branch
feature/base-spatialparams-v2
- 925404a6 - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- a296d196 - [freeflow][problem] Update the freeflow problems to include the spatialParams
- cbd7d66f - [freeflow] update all extrusion factor calls to the spatialParams
- a78b5a5f - [test] shallow water tests update to new spatial parameters
- ad1dc57a - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- 2aa2acc6 - [test][multidomain][stokesdarcy] Update tests to new spatial params
- 3bf9de6a - [test][multidomain][freeflowporenetwork] Update test to include the extrusion...
Toggle commit list-
02f1b4e5...3feb301e - 57 commits from branch
added 16 commits
-
3bf9de6a...fbdd6f12 - 9 commits from branch
feature/base-spatialparams-v2
- 4b3189fd - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- 2018fd3b - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 2ff06262 - [freeflow] update all extrusion factor calls to the spatialParams
- 883de628 - [test] shallow water tests update to new spatial parameters
- f394e469 - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- 7654057f - [test][multidomain][stokesdarcy] Update tests to new spatial params
- a8e8a068 - [test][multidomain][freeflowporenetwork] Update test to include the extrusion...
Toggle commit list-
3bf9de6a...fbdd6f12 - 9 commits from branch
added 9 commits
-
a8e8a068...4cf88950 - 2 commits from branch
feature/base-spatialparams-v2
- c2e583ea - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- 1e336844 - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 521bcb15 - [freeflow] update all extrusion factor calls to the spatialParams
- 5498d05e - [test] shallow water tests update to new spatial parameters
- 5295a096 - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- 12a0665f - [test][multidomain][stokesdarcy] Update tests to new spatial params
- c3c636c2 - [test][multidomain][freeflowporenetwork] Update test to include the extrusion...
Toggle commit list-
a8e8a068...4cf88950 - 2 commits from branch
added 98 commits
-
c3c636c2...a91443b0 - 91 commits from branch
feature/base-spatialparams-v2
- 04bae1a6 - [freeflow][spatialparams] Introduce a spatialparams class for the freeflow models
- a9d929f2 - [freeflow][problem] Update the freeflow problems to include the spatialParams
- 506912c1 - [freeflow] update all extrusion factor calls to the spatialParams
- 373bb8c7 - [test] shallow water tests update to new spatial parameters
- af978af6 - [test][freeflow][spatialparams] adjust freeflow tests with spatial params
- 07c7fc99 - [test][multidomain][stokesdarcy] Update tests to new spatial params
- 9bc94fc3 - [test][multidomain][freeflowporenetwork] Update test to include the extrusion...
Toggle commit list-
c3c636c2...a91443b0 - 91 commits from branch