Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 89
    • Merge requests 89
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !3031

Modify the bed shear stress calculation within the shallow water friction laws.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Utz requested to merge fix/doc-shallowwater-frictionlaws into master Mar 15, 2022
  • Overview 61
  • Commits 2
  • Changes 11

The function shearStress returns the bed shear stress normalized by the water density. This normalisation is unfavourable, since the name of the function (and also the documentation) does not reflect it. Also the name shearStress itself is confusing, since the bed shear stress is not a classical shear stress tensor. The name bedShearStress is more clear, since it points to the context of shallow water equations.

TODOs:

  • Modify the function shearStress to return the bed shear stress and not the bed shear stress normalized by the water density.
  • Return the positive shear stress
  • Rename shearStress to bedShearStress
  • Improve docs
Edited Apr 07, 2022 by Timo Koch
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/doc-shallowwater-frictionlaws