Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3033

[fix][richards] Extended richards: Fix balancequationoptions and do porosity update before evaluating effective diffusion coefficients

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Katharina Heck requested to merge fix/richards-enable-diffusion-in-air into master Mar 23, 2022
  • Overview 16
  • Commits 2
  • Pipelines 6
  • Changes 7

What this MR does / why does DuMux need it: The richards model never overwrote the balancequation options, which is why, although diffusion was calculated (for the extendend Richards model that considers water diffusion in the gas phase), it was immediatly also substracted, leading to a net diffusive flux of 0. With the richards-specific balancequationopts it depends on the phase index if diffusion is balanced or not. Additionally, the porosity in the volumevariables was updated at the wrong place, now it is updated before the effective diffusion coefficient. This correction also made it necessary to change the boundary condition in the richards evaporation tests. a fixed value does not work if the liquid phase actually disappears.

fixes #1134 (closed)

Edited Apr 01, 2022 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/richards-enable-diffusion-in-air