Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 91
    • Merge requests 91
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3095

[bugfix][gridgeometry] Always construct bboxtree and element map

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge fix/grid-geom-thread-safe into master May 03, 2022
  • Overview 3
  • Commits 2
  • Pipelines 2
  • Changes 2

A thread-safe implementation with double-checked lock needs atomic load/store operations to update the pointer to be thread-safe. Alternatively, a lock has to be acquired every time when the function is called. Both implementations impair the scalability of the multihreaded assembly (in the case of tpfa, or any simulation that uses element maps or bounding box tree on an element level).

This changes the beahviour to always build the tree and the element map. This usually occurs little runtime overhead in cases where the features are unused. It is the most performant version as soon as one of the features is used. There is however some memory overhead in the order of one or more ints per element (seeds) and a bounding box hierarchy.

Fixes #1151 (closed)

Edited May 03, 2022 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/grid-geom-thread-safe