Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3162

[cleanup][test][porenetwork] removing setPreviousSolution call

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kai Wendel requested to merge cleanup/remove-setprevioussolution-function into master Jun 03, 2022
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 3

There are only three tests that use a function call in the form of assembler->setPreviousSolution(xOld). If this line is deleted and the tests compiled again, they perform exactly in the same way as before, therefore I would suggest, to remove this call as access to the old solution is already given when the constructor of the assembler is called.

This raises the question, whether this setPreviousSolution() method shall be deleted completely, as it is not called anywhere else except those three tests, or if it is maybe left as it could be used under other circumstances

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cleanup/remove-setprevioussolution-function