Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 89
    • Merge requests 89
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3173

WIP: encapsulate operations in the volvars update method

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ned Coltman requested to merge feature/encapsulate_volvals_updatelogic into master Jun 29, 2022
  • Overview 25
  • Commits 13
  • Pipelines 8
  • Changes 15

What this MR does / why does DuMux need it:

This merge request should remove duplicated code often seen in the volvars' update functions. This issue is outlined in #814.

Notes for the reviewer @tufan, @nedc, @hanchuan, @yue

**Question: ** does it make sense to add new headers to the dumux/material/constraintsolvers/ directory, or would another location make more sense?

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/encapsulate_volvals_updatelogic