Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 102
    • Issues 102
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3284

Fix/tabulated component multithreading

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge fix/tabulated-component-multithreading into master Sep 21, 2022
  • Overview 11
  • Commits 10
  • Pipelines 17
  • Changes 8

What this MR does / why does DuMux need it:

Fixes #1185 (closed)

  • Makes usage of tabularized component thread-safe if a multithreading environment is enabled
  • Uses multithreading for the tabularization
  • C++ style casts instead of C-style casts
  • Improves memory usage of tabularization if a component is only used as liquid or gas
  • Some cleanups

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited Sep 24, 2022 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/tabulated-component-multithreading