Skip to content

Avoid duplicated checkPoints

Martin Utz requested to merge avoid-duplicated-checkPoints into master

What this MR does / why does DuMux need it:

Currently it is possible to set several checkpoints at the same time step. This seems to be a bug, since it yields to a time step size of 0.0, which causes a crash of the Newton solver due to Nan values.

Notes for the reviewer

Is there any use case for several checkPoints at the same time, which I don't consider?

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Timo Koch

Merge request reports