Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 98
    • Issues 98
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3426

Add dualnetwork test from dumux-pub repository Koch2021a

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Anna Mareike Kostelecky requested to merge feature/dualnetwork into master Mar 08, 2023
  • Overview 71
  • Commits 35
  • Pipelines 33
  • Changes 35

What this MR does / why does DuMux need it:

This adds the possibility to study the heat transfer between one fluid phase and a solid phase with one porenetwork model for the void space coupled to one network model for the solid phase (dualnetwork)

In addition one test case is provided with reference solutions

Notes for the reviewer

Files and test case, where taken from https://git.iws.uni-stuttgart.de/dumux-pub/Koch2021a and modified, such that it is runs on the current master

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
  • (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
Edited May 20, 2023 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/dualnetwork