Skip to content

Update docker.opts and inform users of create_docker.py

Mathis Kelm requested to merge update/docker-opts into master

What this MR does / why does DuMux need it:

docker.opts contains cmake options more suitable for docker containers. These haven't been updated in a while. To use them when generating a docker container using the DuMux scripts one must pass the opts file to make_installscript.py before using this in create_docker.py. This should be made more transparent.

Notes for the reviewer

Not sure how best to inform/remind users of the docker script. What other content of docker.opts should be updated?

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.

Merge request reports

Loading