Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3430

[disc][elemsol] put elementSolution() in single group

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Dennis Gläser requested to merge cleanup/elemsol-doxygen-warnings into master Mar 10, 2023
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 6

What this MR does / why does DuMux need it:

The overloads for the free function elementSolution were placed in different doxygen groups. However, the doxygen documentation says

Note that compound entities (like classes, files and namespaces) can be put into multiple groups, but members (like variable, functions, typedefs and enums) can only be a member of one group (this restriction is in place to avoid ambiguous linking targets in case a member is not documented in the context of its class, namespace or file, but only visible as part of a group).

and we get warnings like

/builds/dumux-repositories/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for elementSolution found several times in @ingroup groups!

and ultimately it says

/builds/dumux-repositories/dumux/dumux/discretization/staggered/elementsolution.hh:62: The member will remain in group CCDiscretization, and won't be put into group StaggeredDiscretization

which seems random. This MR proposes to put elementSolution into the Discretization group. All overloads should then be listed when looking at that group, which seems more intuitive.

Edited Mar 10, 2023 by Dennis Gläser
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cleanup/elemsol-doxygen-warnings