Skip to content

Feature/flexible geometry helper

Martin Schneider requested to merge feature/flexible-geometry-helper into master

What this MR does / why does DuMux need it:

As already done for other discretization models, e.g. MPFA or fcstaggered, the geometry helper can be deduced from the Traits class. This offers more flexibility. Furthermore, in the fvelementgeometry.hh the type of the helper is deduced from the gridgeometry.

Notes for the reviewer

This could help unifying grid geometries for CVFE schemes and is for example also needed to easly switch between overlapping and non-overlapping scvs by changing only the helper class

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Timo Koch

Merge request reports