Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 94
    • Merge requests 94
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3466

[cmake] Make sure we build shared libs when Python is enabled and enforce C++17

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Timo Koch requested to merge fix/cmake-python-enable-shared into master Mar 20, 2023
  • Overview 0
  • Commits 4
  • Pipelines 6
  • Changes 4

!3436 (merged) accidentally removed DUMUX_CMAKE_FLAGS which was used in some downstream tests to set BUILD_SHARED_LIBS for Python. The fact that is was removed shows that it wasn't clear what it's good for. We need a better mechanism that actually enforced our requirement of BUILD_SHARED_LIBS=ON when using Python bindings. This attempts to do this through CMake.

We also enforce C++17 by setting it as a PUBLIC interface of the dumux library.

Edited Mar 20, 2023 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/cmake-python-enable-shared