Skip to content

Remove unnecessary define UGGRID 0

Hamza Oukili requested to merge cleanup/remove-unnecessary-def into master

What this MR does / why does DuMux need it:

Since dune 2.6 and OPM 2018.04 are not compatible and give a compiler error, #define HAVE_DUNE_UGGRID 0 has been added. But it produces a warning of "HAVE_DUNE_UGGRID" redefined But now dune 2.9 and OPM 2022.10 seems to be compatible. This MR removes #define HAVE_DUNE_UGGRID 0

Notes for the reviewer

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Hamza Oukili

Merge request reports