What this MR does / why does DuMux need it:
In the old-staggered implementation of Fick's law the fluxes at the boundary use only the (molar) density of the
insideVolVars, while other for other discretizations use the average.
We have decided that when replacing a component balance with a total balance it should always be the total mass and never the total mole balance, even if
With these two changes the results of the test
freeflow/navierstokesnc/densitydriven agree with those of the portet test in !2986 (merged).
Furthermore the enthalpy fluxes due to molecular diffusion compared the sign of the flux to the scvf direction for upwinding purposes but we always compute fluxes out of the scv (fickslaw.hh).
Notes for the reviewer
TODO: insert text here
Before you request a review from someone, make sure to revise the following points:
does the new code follow the style guide?
do the test pipelines pass? (see guide on how to run pipelines for a merge request)
is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
is the list of the header includes complete? ("include what you use")
all files have to end with a
\ncharacter. Make sure there is no
\ No newline at end of filecomment in "Changes" of this MR.
(if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/new?merge_request%5Bsource_branch%5D=fix%2Fold-staggered-fluxes