Skip to content

[PNM][util] add poreExtendedRadius to dgf-file

What this MR does / why does DuMux need it:

Fixes #1254 (closed)

Notes for the reviewer

Before there was only one radius written into .dgf-files which was PoreInscribedRadius, but inside the script saved under the name pore.radius. For pore.radius the extended pore radius of the network was assigned.

Now, we distinguish between the inscribed and the extended radius. The PoreInscribedRadius/pore.inscribedRadius and PoreExtendedRadius/pore.extendedRadius is now obtained from the inscribed and extended radius of the network. If the inscribed radius is not part of the parameters of the network, the extended radius of the network will be assigned to pore.inscribedRadius as it was done before.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Anna Mareike Kostelecky

Merge request reports