Skip to content

[test][pm][2pncmin][ni] rename mole and mass fractions

Anna Mareike Kostelecky requested to merge fix/2pncmin_moleToMassFrac into master

What this MR does / why does DuMux need it:

This MR addresses comments stated in !3740 (merged) . Hence, it renames mass and mole fractions to stick to naming conventions and make it easier to read.

As well it fixes a wrong molar mass used in converting mole to mass fractions.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Timo Koch

Merge request reports