Skip to content

Cleanup/box facet dof enrichment

Dennis Gläser requested to merge cleanup/box-facet-dof-enrichment into master

What this MR does / why does DuMux need it:

The box-facet-coupling model requires duplication of dofs in the bulk domain at faces coinciding with fractures in order to capture potential jumps in the solution across the fractures. At fracture tips ending inside the bulk domain, or on fractures that coincide with the bulk domain boundary, no duplication occurs. However, at fractures tips located at the bulk domain boundary, duplication does occur.

One case that wasn't handled properly yet is what's shown in the pictures in the comments below. This MR fixes that.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Dennis Gläser

Merge request reports