Skip to content

Fix/facet coupling on boundary

Dennis Gläser requested to merge fix/facet-coupling-on-boundary into master

What this MR does / why does DuMux need it:

The facet-coupling framework seems to not have worked for the case of lower-dimensional domains coinciding with the bulk domain boundary, as was reported to me in private by an external user. In particular, I observed that:

  • the box scheme led to wrong results when Dirichlet boundary conditions were specified at the boundaries coinciding with a lower-dimensional domain (the Dirichlet values were set and the residual was thrown away)
  • the specialization of evalFluxes in the CCFacetCouplingLocalResidual was actually not called (at least with my compiler), but the one of the parent class -> leading to wrong treatment at boundaries that are "interior" and "exterior" at the same time...
  • for mpfa, the face count was wrong in interaction volumes that have "interior boundary" faces that are "exterior" ones at the same time.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Dennis Gläser

Merge request reports