Skip to content

Draft: Feature/hybrid cvfe

Martin Schneider requested to merge feature/hybrid-cvfe into master

What this MR does / why does DuMux need it:

Implementation of hybrid pq1bubble cvfe scheme

Notes for the reviewer

The following points need to be discussed:

  • When not using default template parameters, then the gridGeometry interface is not backwards compatible. I am not sure if we need to be backwards compatible, because it is probably not yet used very often. If we want to be, then we could move enableHybridCVFE after Traits of we add it to the Traits class --> added to traits
  • Think about how to get rid of building scvs for hybrid dofs
  • Can we rely on C+20? As a first solution I used ranges to easily iterate over localDofs. In the long term we could introduce a new concept of a container storing just some local dof information. --> even easier in Dune, no need here yet. I also transform it now to return a dof class.
  • Naming: I currently use evalElementFluxAndSource and evalElementStorage it seemed to be the most consistent ones. But maybe we find better ones.
  • I did not yet implement a new source function interface but I assume that there is a soureAtPos implemented.
  • The same for boundary handling. We have to think if it is possible to use the current interface which gets the bcType from scv. Currently I assume that there are ***atPos() functions.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
  • (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
  • (if not applicable remove) if the examples are modified, is the documentation regenerated (using generate_example_docs.py)
Edited by Timo Koch

Merge request reports