Skip to content

Draft: Feature/pnm ff add interface pore body velocity

What this MR does / why does DuMux need it: For coupling pore network model to a free-flow domain, we couple the pore bodies to the free-flow grid cells. Until now, the velocity of the throat was used for calculating the slip velocity by a local Beaver-Joseph slip condition. However, the throat is not directly coupled to the free-flow grid cells, but the pore bodies. As also the cross-sectional area of the pore bodies comes indirectly into the coupling conditions (the faces of the coupled free-flow cells should have the same area as the cross-sectional area of the coupled pore body (at least in 2D)), the velocity in the pore body should be used for obtaining the slip velocity.

We (@Maziar, @anna_m_kostelecky) propose a simple scaling of the throat velocity by the fraction of throatCrossSectionalArea over poreBodyCrossSectionalArea.

Notes for the reviewer

TODO: insert text here

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Anna Mareike Kostelecky

Merge request reports

Loading